Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change handle_import_statements to FatalResult #6820

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Change handle_import_statements to FatalResult #6820

merged 2 commits into from
Mar 4, 2023

Conversation

BradleyOlson64
Copy link
Contributor

See #4396

@BradleyOlson64 BradleyOlson64 changed the title Change handle_import_statements to FatalError Change handle_import_statements to FatalResult Mar 3, 2023
@BradleyOlson64 BradleyOlson64 self-assigned this Mar 3, 2023
@BradleyOlson64 BradleyOlson64 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 3, 2023
@BradleyOlson64 BradleyOlson64 linked an issue Mar 3, 2023 that may be closed by this pull request
dispute-coordinator: Make handle_import_statements return FatalResult #4396
Closed
eskimor
eskimor approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@eskimor eskimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eskimor eskimor merged commit c02e1b4 into master Mar 4, 2023
@eskimor eskimor deleted the brad-issue-4396 branch March 4, 2023 18:35
s0me0ne-unkn0wn pushed a commit that referenced this pull request Mar 6, 2023
@BradleyOlson64 @s0me0ne-unkn0wn
Change handle_import_statements to FatalResult (#6820)
e16adb6 
* Changing dispute db errors to fatal

* fmt
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
5046c2d 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
f2119e4 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
paritytech-processbot bot pushed a commit that referenced this pull request Mar 8, 2023
@s0me0ne-unkn0wn @mrcnski
@BradleyOlson64 @pmensik @tdimitrov
Move PVF timeouts to executor environment parameters (#6823)
0122e14 
* Move PVF timeouts to executor environment parameters

* Typo

Co-authored-by: Marcin S. <marcin@realemail.net>

* Fix comments

* Change handle_import_statements to FatalResult (#6820)

* Changing dispute db errors to fatal

* fmt

* Change node-key for bootnodes (#6772)

* Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)

* Additional tracing in `provisioner`, `vote_selection`

* Add `fetched_onchain_disputes` metric to provisioner

* Some tracelines in dispute-coordinator

TODO: cherry pick this in the initial branch!!!

* Remove spammy logs

* Remove some trace lines

* Rename and fix things

* Fix comments

* Typo

* Minor fixes

* Add codec indexes; Remove macro

---------

Co-authored-by: Marcin S. <marcin@realemail.net>
Co-authored-by: Bradley Olson <34992650+BradleyOlson64@users.noreply.github.com>
Co-authored-by: Petr Mensik <petr.mensik1@gmail.com>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandreim sandreim sandreim approved these changes

@eskimor eskimor eskimor approved these changes

@tdimitrov tdimitrov Awaiting requested review from tdimitrov

Assignees

@BradleyOlson64 BradleyOlson64

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dispute-coordinator: Make handle_import_statements return FatalResult
3 participants
@BradleyOlson64 @eskimor @sandreim