This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Kusama state version switch and migration. #7015
Merged
paritytech-processbot
merged 11 commits into
paritytech:master
from
cheme:kusuma-migration2
Jul 4, 2023
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b790797
State version switch and migration init
cheme 4a8a379
fix
cheme dcdefbe
migration declaration (last position, westend was first)
cheme a69b387
Merge branch 'master' into kusuma-migration2
cheme 707b986
revert unrelated cargo fmt
cheme f4bc170
move to unrelease
cheme 925074a
fmt?
cheme efa685a
fmt
cheme bdd9ae3
Change size of processing per blocks
cheme 9f4c073
Merge branch 'master' into kusuma-migration2
cheme 18cc436
Dispatch error
cheme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no fan of what rustfmt does here.
The list you had before is much more readable.
I would suggest adding
#[rustfmt_skip]
for thisMigrations
type as well as forUnreleased
and keep one migration / version per line. That also helps with your comment about having this single migration in a release.