This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
BEEFY & MMR zombienet tests #7068
Merged
acatangiu
merged 27 commits into
paritytech:master
from
Lederstrumpf:rhmb/beefy-mmr-zombienet-tests
May 4, 2023
Merged
BEEFY & MMR zombienet tests #7068
acatangiu
merged 27 commits into
paritytech:master
from
Lederstrumpf:rhmb/beefy-mmr-zombienet-tests
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems this doesn't pass some regex
Lederstrumpf
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Apr 13, 2023
Lederstrumpf
force-pushed
the
rhmb/beefy-mmr-zombienet-tests
branch
from
April 13, 2023 09:17
62992be
to
909a7f7
Compare
serban300
reviewed
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionally. Just left a couple of comments related to cosmetics.
acatangiu
reviewed
Apr 17, 2023
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Serban Iorga <serban@parity.io>
don't randomize selection of proof generating / finalized head retrieving node, but use the node arg for this.
Co-authored-by: Adrian Catangiu <adrian@parity.io>
acatangiu
approved these changes
May 1, 2023
picks the node with the highest finalized head, gets its blockchain headers since genesis, and verifies that all other nodes' finalized heads are in said blockchain.
Co-authored-by: Serban Iorga <serban@parity.io>
bot rebase |
serban300
approved these changes
May 1, 2023
bot rebase |
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds zombienet tests which ensure that the JS API is aligned with nodes' BEEFY & MMR RPC APIs, and also verifies that nodes agree on their offchain db storage:
Closes paritytech/substrate#11972.