Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BEEFY & MMR zombienet tests #7068

Merged

Conversation

Lederstrumpf
Copy link
Contributor

This PR adds zombienet tests which ensure that the JS API is aligned with nodes' BEEFY & MMR RPC APIs, and also verifies that nodes agree on their offchain db storage:

  1. for BEEFY RPC, confirm that nodes agree on the finalized head.
  2. for MMR RPC, confirm that proofs generated by some node can be successfully verified against the MMR storage of another node.

Closes paritytech/substrate#11972.

@Lederstrumpf Lederstrumpf added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 13, 2023
@Lederstrumpf Lederstrumpf force-pushed the rhmb/beefy-mmr-zombienet-tests branch from 62992be to 909a7f7 Compare April 13, 2023 09:17
@serban300 serban300 self-requested a review April 13, 2023 09:27
Copy link
Contributor

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionally. Just left a couple of comments related to cosmetics.

Lederstrumpf and others added 7 commits April 19, 2023 23:57
Co-authored-by: Serban Iorga <serban@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Serban Iorga <serban@parity.io>
don't randomize selection of proof generating / finalized head
retrieving node, but use the node arg for this.
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Lederstrumpf and others added 2 commits May 1, 2023 11:59
picks the node with the highest finalized head, gets its blockchain
headers since genesis, and verifies that all other nodes' finalized
heads are in said blockchain.
Co-authored-by: Serban Iorga <serban@parity.io>
@acatangiu
Copy link
Contributor

bot rebase

@acatangiu
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Rebased

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zombienet: add test for BEEFY and MMR RPCs
3 participants