Skip to content
This repository has been archived by the owner on Apr 2, 2020. It is now read-only.

Use network specific critical flag #14

Merged
merged 4 commits into from
Jun 8, 2018
Merged

Use network specific critical flag #14

merged 4 commits into from
Jun 8, 2018

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Jun 6, 2018

rel openethereum/parity-ethereum#8821.

Allows specifying whether a given release is critical per network.

@ascjones ascjones requested a review from tomusdrw June 6, 2018 16:55
tomusdrw
tomusdrw reviewed Jun 6, 2018
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Maybe it would be better to temporarily support both formats (i.e. first check network-specific, later meta if not defined).

I think it would make it easier to handle the transition period.

Also could we get tests for both cases?

@ascjones ascjones force-pushed the aj-network-specific-critical-flag branch from 4f12dfc to f78ec84 Compare June 7, 2018 13:27
@tomusdrw tomusdrw merged commit ec2a28b into master Jun 8, 2018
@tomusdrw tomusdrw deleted the aj-network-specific-critical-flag branch June 8, 2018 12:44
@ascjones ascjones mentioned this pull request Jun 8, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascjones @tomusdrw