Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type id to new type id in PortableRegistry::retain(). #204

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Change type id to new type id in PortableRegistry::retain(). #204

merged 3 commits into from
Mar 22, 2024

Conversation

tadeohepperle
Copy link
Contributor

@tadeohepperle tadeohepperle commented Mar 22, 2024 •
edited
Loading

The type's id should be set to the new id to reflect the correct position in the Vec holding the types of the PortableRegistry.

See the comment of @jsdw here: paritytech/scale-typegen#23 (comment)

jsdw
jsdw reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing; this was missed in our retain tests before, so could we tweak the tests to make sure this works too? :)

@jsdw jsdw merged commit 938790b into master Mar 22, 2024
2 checks passed
@jsdw jsdw deleted the tadeohepperle/fix-type-id-in-retain branch March 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tadeohepperle @jsdw @niklasad1 @lexnv