Remove version field from struct returned by rpc_methods (#2756)

Mimics the change done here: paritytech/substrate#12261 Let's merge this PR only if paritytech/substrate#12261 is approved and merged.
paritytech · Sep 23, 2022 · 3b8bfb4 · 3b8bfb4
1 parent b5a823d
commit 3b8bfb4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/bin/light-base/src/json_rpc_service/getters.rs b/bin/light-base/src/json_rpc_service/getters.rs
@@ -127,7 +127,6 @@ impl<TPlat: Platform> Background<TPlat> {
             .respond(
                 state_machine_request_id,
                 methods::Response::rpc_methods(methods::RpcMethods {
-                    version: 1,
                     methods: methods::MethodCall::method_names()
                         .map(|n| n.into())
                         .collect(),

diff --git a/bin/wasm-node/CHANGELOG.md b/bin/wasm-node/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Changed
+
+- Removed the `version` field of the struct returned by the `rpc_methods` function. This is technically a breaking change, but it has been introduced in a minor version bump because it is very insubstantial. ([#2756](https://github.com/paritytech/smoldot/pull/2756))
+
 ## 0.6.34 - 2022-09-20
 
 ### Added
@@ -11,7 +15,7 @@
 
 ### Changed
 
-- No longer try to connect to a peer for 20 seconds after failing to connect to it. This prevents loops where we keep trying to connect to the same address(es) over and over again ([#2747](https://github.com/paritytech/smoldot/pull/2747)).
+- No longer try to connect to a peer for 20 seconds after failing to connect to it. This prevents loops where we keep trying to connect to the same address(es) over and over again. ([#2747](https://github.com/paritytech/smoldot/pull/2747))
 
 ### Fixed
 

diff --git a/src/json_rpc/methods.rs b/src/json_rpc/methods.rs
@@ -889,7 +889,6 @@ pub struct NetworkConfig {
 
 #[derive(Debug, Clone)]
 pub struct RpcMethods {
-    pub version: u64,
     pub methods: Vec<String>,
 }
 
@@ -1054,12 +1053,10 @@ impl serde::Serialize for RpcMethods {
     {
         #[derive(serde::Serialize)]
         struct SerdeRpcMethods<'a> {
-            version: u64,
             methods: &'a [String],
         }
 
         SerdeRpcMethods {
-            version: self.version,
             methods: &self.methods,
         }
         .serialize(serializer)