Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RuntimeService::block_runtime_code_heap_pages #1787

Closed
wants to merge 1 commit into from
Closed

Add RuntimeService::block_runtime_code_heap_pages #1787

wants to merge 1 commit into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Dec 15, 2021

cc #1769

This PR will fail CI because of an unused function warning, but it paves the way for #1769.

mergify[bot]
mergify bot approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
        +262 ┊ Σ [0 Total Rows]

@tomaka
Copy link
Contributor Author

tomaka commented Dec 15, 2021

Don't ask me why adding an unused method increases the size of the binary.

melekes
melekes reviewed Jan 18, 2022
View reviewed changes
bin/light-base/src/runtime_service.rs
.input_iter_unordered()
.find(|block| block.user_data.hash == *block_hash)
.and_then(|block| block.async_op_user_data)?
.unwrap(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it always safe to unwrap here?

@tomaka
Copy link
Contributor Author

tomaka commented Oct 4, 2022 •
edited
Loading

I'm going to close this. It's only 40 lines of code with a merge conflict. While these lines of code may be useful in the distant future, it's better to clean up the list of PRs at this point.

@tomaka tomaka closed this Oct 4, 2022
@tomaka tomaka deleted the block-runtime-code-heap-pages branch October 4, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes left review comments

@mergify Mergify Mergify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes