Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a CHANGELOG for the wasm node #2122

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 7, 2022

After this PR is merged, every noticeable PR that concerns the wasm node should update this CHANGELOG.

I'm not including changes such as #2073 because they only concern the full node.

We could consider adding a CI action that checks whether the CHANGELOG respects a certain format, but I haven't found anything great.
We could also consider adding a CI action that reminds you to add a CHANGELOG entry if you didn't (unless you explicitly say "this doesn't need a changelog entry"), but that also seems kind of complicated.

@tomaka tomaka requested a review from melekes March 7, 2022 08:45
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

bin/wasm-node/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Mar 7, 2022
@mergify mergify bot merged commit 40a24f8 into paritytech:main Mar 7, 2022
@tomaka tomaka deleted the changelog branch March 7, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants