Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs errors as Debug and not Display #2161

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Logs errors as Debug and not Display #2161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a41ba9c
Logs errors as Debug and not Display
tomaka Mar 22, 2022
24645e4
Changelog
tomaka Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/light-base/src/network_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ impl<TPlat: Platform> NetworkService<TPlat> {
} => {
log::debug!(
target: "network",
"Connection({}, {}) => ChainConnectAttemptFailed(error={})",
"Connection({}, {}) => ChainConnectAttemptFailed(error={:?})",
&network_service.log_chain_names[chain_index],
peer_id, error,
);
Expand Down Expand Up @@ -349,7 +349,7 @@ impl<TPlat: Platform> NetworkService<TPlat> {
// TODO: handle properly?
log::warn!(
target: "network",
"Connection({}) => ProtocolError(error={})",
"Connection({}) => ProtocolError(error={:?})",
peer_id,
error,
);
Expand Down Expand Up @@ -691,7 +691,7 @@ impl<TPlat: Platform> NetworkService<TPlat> {
Err(err) => {
log::debug!(
target: "network",
"Connection({}) => BlocksRequest(chain={}, error={})",
"Connection({}) => BlocksRequest(chain={}, error={:?})",
target,
self.inner.log_chain_names[chain_index],
err
Expand Down Expand Up @@ -751,7 +751,7 @@ impl<TPlat: Platform> NetworkService<TPlat> {
Err(err) => {
log::debug!(
target: "network",
"Connection({}) => GrandpaWarpSyncRequest(chain={}, error={})",
"Connection({}) => GrandpaWarpSyncRequest(chain={}, error={:?})",
target,
self.inner.log_chain_names[chain_index],
err,
Expand Down Expand Up @@ -832,7 +832,7 @@ impl<TPlat: Platform> NetworkService<TPlat> {
Err(err) => {
log::debug!(
target: "network",
"Connection({}) => StorageProofRequest(chain={}, error={})",
"Connection({}) => StorageProofRequest(chain={}, error={:?})",
target,
self.inner.log_chain_names[chain_index],
err
Expand Down
2 changes: 1 addition & 1 deletion bin/light-base/src/runtime_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1676,7 +1676,7 @@ async fn run_background<TPlat: Platform>(
Err(error) => {
log::debug!(
target: &log_target,
"Worker <= FailedDownload(blocks=[{}], error={})",
"Worker <= FailedDownload(blocks=[{}], error={:?})",
concerned_blocks,
error
);
Expand Down
4 changes: 2 additions & 2 deletions bin/light-base/src/sync_service/parachain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ pub(super) async fn start_parachain<TPlat: Platform>(

log::debug!(
target: &log_target,
"ParaheadFetchOperations => Error(relay_blocks={}, error={})",
"ParaheadFetchOperations => Error(relay_blocks={}, error={:?})",
async_tree.async_op_blocks(async_op_id).map(|b| HashDisplay(b)).join(","),
error
);
Expand Down Expand Up @@ -594,7 +594,7 @@ async fn parahead<TPlat: Platform>(
}
}

#[derive(derive_more::Display)]
#[derive(Debug, derive_more::Display)]
enum ParaheadError {
Call(runtime_service::RuntimeCallError),
StartError(host::StartErr),
Expand Down
4 changes: 2 additions & 2 deletions bin/light-base/src/sync_service/standalone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ impl<TPlat: Platform> Task<TPlat> {
// TODO: print which peer sent the header
log::debug!(
target: &self.log_target,
"Sync => HeaderVerifyError(hash={}, error={})",
"Sync => HeaderVerifyError(hash={}, error={:?})",
HashDisplay(&verified_hash),
error
);
Expand Down Expand Up @@ -644,7 +644,7 @@ impl<TPlat: Platform> Task<TPlat> {
// TODO: print which peer sent the justification
log::debug!(
target: &self.log_target,
"Sync => JustificationVerificationError(error={})",
"Sync => JustificationVerificationError(error={:?})",
error,
);

Expand Down
4 changes: 4 additions & 0 deletions bin/wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
- Add `ClientOptions.cpuRateLimit`, which lets the user put an upper bound on the amount of CPU that the client uses on average ([#2151](https://github.com/paritytech/smoldot/pull/2151)).
- Add support for parsing the "fron" (Frontier) consensus log items in headers. The content of these log items is ignored by the client. ([#2150](https://github.com/paritytech/smoldot/pull/2150))

### Changed

- Add more details to the debug and trace logs that happen in case of errors such as networking errors or block verification failures ([#2161](https://github.com/paritytech/smoldot/pull/2161)).

## 0.6.5 - 2022-03-17

### Changed
Expand Down