-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interleave CPU-heavy operations with I/O events in the sync service #2213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
Err(()) | ||
} | ||
}; | ||
.map_err(|_| ()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮
Fix #2209
Right now, if the sync service is verifying a warp sync proof, in the meanwhile it doesn't respond to any event anymore.
This causes queues of operations to grow in size, and thus in latency, which causes other kind of small problems to manifest.
This PR makes sure that the sync service processes events at a certain minimum rate by interleaving CPU-heavy operations with responding to events.