Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LEB128-related panic again #2337

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Fix LEB128-related panic again #2337

merged 4 commits into from
Jun 7, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jun 6, 2022

Similar to #2326 (comment)

We actually have two LEB128 decoding codes: one when the data is complete and one when the data is maybe incomplete, and I forgot about this.

mergify[bot]
mergify bot approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────
          +1 ┊ smoldot::util::leb128::FramedInProgress::update::h36f6b362d0ce9d95
          +1 ┊ Σ [1 Total Rows]

melekes
melekes approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jun 7, 2022
@mergify mergify bot merged commit f2748c2 into paritytech:main Jun 7, 2022
@tomaka tomaka deleted the panic-leb-again branch June 7, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes