Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust JS API to support multi-stream connections #2546

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Adjust JS API to support multi-stream connections #2546

merged 2 commits into from
Jul 21, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 21, 2022

cc #1712

Adjusts the JS code that binds the index-* files to the Wasm VM that runs smoldot.
It now supports multi-stream connections.

mergify[bot]
mergify bot approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

melekes
melekes approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Jul 21, 2022
@mergify mergify bot merged commit 593c661 into paritytech:main Jul 21, 2022
@tomaka tomaka deleted the multistream-connections-js branch July 21, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes