Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to runtime service subscriptions #2631

Merged
merged 2 commits into from
Aug 14, 2022
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 14, 2022

Adds a name parameter when subscribing to the runtime service.

These names have been useful in the past in order to debug things locally, but I've never actually left them in the source code.
I think it makes sense to leave them.

Should make debugging #2617 easier the next time it happens

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
      +13417 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hcbc3bb6dd5eaacc0
      -13396 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h688777836623a41f
      +12085 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h29ee2d6216cd4fb2
      -12064 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h05233862b8c2915b
       +2580 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hcf1b6f2bccf9b2f1
       -2564 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h03645844a1833d1b
       +1922 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc2e5448dc95588e3
       -1901 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc031b299e5aa995f
       +1764 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3f4639df7c308a4e
       -1744 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h63f52e0ad880d4a5
       +1630 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hbd751c6160436082
       -1609 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h52267b0a55c677df
       +1562 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h41f004fdf04b2be7
       -1542 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6cb5398cee74949b
       +1344 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h68b716c06f19e0c6
       -1344 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h898b9c10e092f775
       +1071 ┊ hashbrown::raw::RawTable<T,A>::reserve_rehash::h9464d9f910cc57a8
       -1039 ┊ hashbrown::raw::RawTable<T,A>::reserve_rehash::hbee73128b964e9bf
       +1011 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf15ce64387cc743d
        -992 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc43201e00ce2a545
        +507 ┊ ... and 156 more.
        +728 ┊ Σ [176 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Aug 14, 2022
@mergify mergify bot merged commit a63ac12 into paritytech:main Aug 14, 2022
@tomaka tomaka deleted the rt-sub-name branch August 14, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant