Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peers are now banned for 20 seconds after a protocol error or substream refusal #2633

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 15, 2022

Close #1250

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@tomaka tomaka changed the title Peers are now banned for 20 seconds Peers are now banned for 20 seconds after a protocol error or substream refusal Aug 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
       +8612 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hcf51c8e2b6ff39ae
       -8137 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha0e5533796788447
       +3385 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h0664d1b2bfacc0bb
       -3385 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::haecf0fe627045f75
       -3060 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h4112ef349f9e4ef8
       +3060 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h689020244f736b7b
       -2596 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h12d9c44ab22c6f9e
       +2596 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hef8cf5fb037f43ec
       +2503 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h597c41d5fea0ed29
       -2503 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hc82535235449232a
       +2075 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h241418674c1375aa
       -2075 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf6dd731333ab048e
       -1999 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h9583bc7a581a3b8e
       +1999 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha1b789e3fda4c703
       -1999 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb26eefd64bab7981
       +1999 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hdc5d01c3c3db1cd4
       +1754 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hcbb764734dce8e79
       -1754 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd662feee57fd5cea
       -1571 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h2b1ed723c82372bf
       -1571 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3021dd7a65b8032a
       +6673 ┊ ... and 437 more.
       +8143 ┊ Σ [457 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Aug 15, 2022
@mergify mergify bot merged commit af5e811 into paritytech:main Aug 15, 2022
@tomaka tomaka deleted the network-bans branch August 15, 2022 12:52
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force-disconnect peers that trigger errors in the node
2 participants