Fix #2617

[tomaka]

Fix #2617

The code that this PR touches was completely wrong, and probably got lost in an earlier refactoring.

[mergify]

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

[github-actions]

twiggy diff report

Difference in .wasm size before and after this pull request.

---

 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +1023 ┊ smoldot_light::sync_service::parachain::start_parachain::{{closure}}::h8061ad0acae26644
        +984 ┊ hashbrown::raw::RawTable<T,A>::reserve_rehash::he6b013d72a161751
        -402 ┊ core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut::h305b9a50768ad49b
        -392 ┊ itertools::Itertools::join::h4c8141177e0d3245
        +392 ┊ itertools::Itertools::join::h80d04efafff84355
        +392 ┊ itertools::Itertools::join::hc1341ba8b1109dbd
        -392 ┊ itertools::Itertools::join::hc5bc1b70b523b48d
        +330 ┊ hashbrown::map::HashMap<K,V,S,A>::entry::h5b7c0bd8e476538b
        +270 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::h81de1353b1ccf480
        -270 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::hf0b711e0b28d8239
        -259 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::hd7049b7d9f6bc15f
        +244 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::h3c0674eeea1a458c
        +241 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h0685e207828d9090
        -241 ┊ core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &mut F>::call_once::h56da2e0079c7be48
        -240 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold::he0a248fe77b21cd6
        +233 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::h175a61b31ed7514e
        -233 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::h33a14acd9de555d7
        +223 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::h7618e5b5fa502577
        -223 ┊ <alloc::vec::Vec<T> as alloc::vec::spec_from_iter_nested::SpecFromIterNested<T,I>>::from_iter::hede0ef6b113f06e3
        +177 ┊ hashbrown::raw::RawIterRange<T>::next_impl::hfb1fd6c12d3dcd68
       +1521 ┊ ... and 65 more.
       +5436 ┊ Σ [85 Total Rows]

[melekes]

👍

[tomaka]

Fixed a bug in the PR: if the parablock of a non-finalized relay block is the same as the finalized parablock, we would report this parablock as non-finalized anyway.