Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for system_nodeRoles #2725

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 8, 2022

No description provided.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      +10876 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hba6e29a37a546033
      -10784 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h520e1e7cef22679f
       +1493 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::h2628c7c655bdbe99
       -1475 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>::handle_request::{{closure}}>>::hf958810b94be0ff4
        +516 ┊ smoldot::json_rpc::methods::_::<impl serde::de::Deserialize for smoldot::json_rpc::methods::StorageQueryType>::deserialize::hc4645e087fdd7cc2
        -516 ┊ smoldot::json_rpc::methods::_::<impl serde::de::Deserialize for smoldot::json_rpc::methods::StorageQueryType>::deserialize::heb46b1f84edc590e
        -484 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::RuntimeSpec>::serialize::h58ef3a1efca80df8
        +484 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::RuntimeSpec>::serialize::h6ae95053ba2df63a
        +478 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::TransactionStatus>::serialize::hd7eb1b808c9c9a85
        -478 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::TransactionStatus>::serialize::hd9aef74d1de12d32
        -470 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::RuntimeVersion>::serialize::h215693a925ab7cf5
        +470 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::RuntimeVersion>::serialize::hd2163b196f89f4a7
        +322 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_str::h572030847a5ee803
        -322 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_str::hb3544cb2ed523764
        +303 ┊ serde::ser::Serializer::collect_seq::hf55227b5aa37312b
        -303 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::SystemPeer>::serialize::h692ab2763a91a3f0
        +303 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::SystemPeer>::serialize::hbba72ecf5e4b5b9c
        -246 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::StorageChangeSet>::serialize::haa25ddcfdfa10159
        +246 ┊ smoldot::json_rpc::methods::_::<impl serde::ser::Serialize for smoldot::json_rpc::methods::StorageChangeSet>::serialize::hd004490bea5868ac
        +227 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hd8442546e3646709
        +636 ┊ ... and 28 more.
       +2223 ┊ Σ [48 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Sep 10, 2022
@mergify mergify bot merged commit eb767a2 into paritytech:main Sep 10, 2022
@tomaka tomaka deleted the system_nodeRoles branch September 10, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants