Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the Noise prologue in the WebRTC handshake #2759

Closed
wants to merge 1 commit into from
Closed

Set the Noise prologue in the WebRTC handshake #2759

wants to merge 1 commit into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 16, 2022

Let's wait for libp2p-webrtc to support this as well before merging this PR.

cc libp2p/rust-libp2p#2903

@tomaka tomaka requested a review from melekes September 16, 2022 12:58
mergify[bot]
mergify bot approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
        +424 ┊ smoldot::libp2p::collection::multi_stream::MultiStreamConnectionTask<TNow,TSubId>::new::h33a2c8aa87839408
         +95 ┊ <alloc::vec::Vec<T,A> as core::cmp::PartialOrd>::partial_cmp::haa56e24ee69ac59d
         -87 ┊ smoldot_light::json_rpc_service::state_chain::<impl smoldot_light::json_rpc_service::Background<TPlat>>::state_get_keys_paged::{{closure}}::{{closure}}::h234086d3023e1a25
         +16 ┊ data[0]
        +560 ┊ Σ [4 Total Rows]

melekes
melekes approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka mentioned this pull request Sep 20, 2022
Closed
2 tasks
@melekes melekes mentioned this pull request Sep 30, 2022
Merged
@melekes
Copy link
Contributor

melekes commented Oct 13, 2022

Closing in favor of #2807.

@melekes melekes closed this Oct 13, 2022
@tomaka tomaka deleted the webrtc-prologue branch October 13, 2022 07:50
mergify bot pushed a commit that referenced this pull request Oct 13, 2022
@melekes @tomaka
set the Noise prologue in the WebRTC handshake (#2807)
3e7ffe1 
Updates #2759
See melekes/rust-libp2p#10 and
libp2p/specs#412 (comment)

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

@melekes melekes melekes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @melekes