Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WebRTC by default #2977

Merged
merged 3 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/wasm-node/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Changed

- The `enableExperimentalWebRTC` field has been removed from `ClientConfig`, and replaced with a `forbidWebRtc` option. WebRTC is now considered stable enough to be enabled by default. ([#2977](https://github.com/paritytech/smoldot/pull/2977))
- Reduced the number of networking round-trips after a connection has been opened by assuming that the remote supports the desired networking protocols instead of waiting for its confirmation. ([#2984](https://github.com/paritytech/smoldot/pull/2984))

## 0.7.6 - 2022-11-04
Expand Down
11 changes: 5 additions & 6 deletions bin/wasm-node/javascript/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,14 +252,13 @@ export interface ClientOptions {
forbidWss?: boolean;

/**
* Enable experimental support for WebRTC connections.
*
* Support for WebRTC connections is currently in progress and might have significant issues.
* If `true`, then the client will never open any WebRTC connection.
* Defaults to `false`.
*
* This flag currently defaults to `false`. In a later version, it will be removed and WebRTC
* connections will be enabled by default.
* This option has no effect in environments where non-secure WebSocket connections aren't
* supported anyway.
*/
enableExperimentalWebRTC?: boolean;
forbidWebRtc?: boolean;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion bin/wasm-node/javascript/src/index-browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function start(options?: ClientOptions): Client {
options?.forbidWs || false,
options?.forbidNonLocalWs || false,
options?.forbidWss || false,
!(options?.enableExperimentalWebRTC || false)
options?.forbidWebRtc || false
)
}
})
Expand Down