Move Merkle proof verification to warp syncing module #3054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the warp syncing code asks "hey I'd like to know the runtime", and the upper layers download a Merkle proof, verify it, and give the storage values to the warp syncing code.
This PR modifies this. The warp syncing code now asks for a Merkle proof of arbitrary keys, and the upper layers download that proof and give to the warp syncing code. It is the warp syncing code that verifies said proof.
The objective of this PR is simplification of the API surface of the syncing code.
It will also make it easier to implement #1769, as it is now clear who is responsible for first downloading only the hash.