Make the close reason available to application code #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
reviewed
Apr 12, 2021
There was a problem hiding this comment.
If I understand correctly the design of this crate, I think this PR has a fundamental problem: the Error::Closed enum as it currently is represents a way to signal to the user that a close frame has been sent/received in the past, and not as a way to signal instantaneously that a close frame has been received.
To me, there should instead of a new variant added to Incoming to contain the close reason. As mentioned, Error::Closed means "you can't do that because the connection is already closed".
Comment on lines
+599
to
+600
| code: u16, | ||
| descr: Option<String>, |
There was a problem hiding this comment.
I suppose you want to access these fields
Suggested change
| code: u16, | |
| descr: Option<String>, | |
| pub code: u16, | |
| pub descr: Option<String>, |
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
|
Closing in favour of #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a remote sends us a
CLOSEmessage it may contain a reason code and "application data" with further details about why the connection was closed.Before this PR there was no way for applications using
sokettoto know what the code/data was sent from the remote.Further context here.