Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add e2e tests to ci #1222

Merged
merged 4 commits into from
Feb 16, 2023
Merged

ci: add e2e tests to ci #1222

merged 4 commits into from
Feb 16, 2023

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Feb 9, 2023 •
edited
Loading

PR adds e2e tests to CI

Close https://github.com/paritytech/ci_cd/issues/734

@alvicsam alvicsam requested a review from a team as a code owner February 9, 2023 10:29
@alvicsam
Copy link
Contributor Author

alvicsam commented Feb 9, 2023

It seems that regex doesn't allow current URLs

@alvicsam alvicsam requested a review from a team as a code owner February 9, 2023 11:16
@alvicsam alvicsam marked this pull request as draft February 9, 2023 11:23
@TarikGul TarikGul changed the title feat: add e2e tests to ci ci: add e2e tests to ci Feb 9, 2023
@TarikGul TarikGul mentioned this pull request Feb 9, 2023
Merged
@TarikGul
Copy link
Member

TarikGul commented Feb 9, 2023

@alvicsam I just fixed some issues and merged in the PR, so if you pull in master it will sort some of the issues out.

  1. added the tests for kusama and westend.

  2. Removed the check for the ws url. Not necessary since we are using this internally. This also means you can remove the port numbers on the ws urls.

@alvicsam alvicsam marked this pull request as ready for review February 16, 2023 15:12
TarikGul
TarikGul approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks :)

@alvicsam alvicsam merged commit 14b05f8 into master Feb 16, 2023
@alvicsam alvicsam deleted the as-ci-e2e branch February 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcny rcny rcny approved these changes

@TarikGul TarikGul TarikGul approved these changes

@marshacb marshacb Awaiting requested review from marshacb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvicsam @TarikGul @rcny