-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: /accounts/{accountId}/convert
encoding for ecdsa
#1280
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old Code
By reading the comments above this test, it was giving as output an invalid address on purpose.
The comments say that the user :
publicKey=true
)and then the output is/should be an invalid address. So that was with the old code.
New Code
With the new code, the output is correct even if the user states that the input is a public key when its not. So in the case of
scheme=ecdsa
, if the user sets query parampublicKey
eithertrue
orfalse
it will go to this new line of code :
ecdsa: (p: string) => (hexToU8a(p).length > 32 ? blake2AsHex(p) : p),
and it will encode correctly despite the value of
publicKey
query param.Thoughts
So, some thoughts based on the above :
publicKey
is needed anymore. Wdyt @TarikGul ? Since it will convert it correctly by checking the length (in theecdsa
case)cc @IkerAlus Thank you for your time on trying to check this. It really helped on clearing my head and checking efficiently after our talk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the
publicKey
query param is not needed anymore. I would say we keep this PR small to first fix the way we deal withecdsa
then we can have some follow up work to remove thepublicKey
query param.👍 Sounds good.