Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(calc): add test for calc_payout #1317

Merged
merged 7 commits into from
Aug 18, 2023
Merged

test(calc): add test for calc_payout #1317

merged 7 commits into from
Aug 18, 2023

Conversation

bee344
Copy link
Contributor

@bee344 bee344 commented Aug 18, 2023 •
edited
Loading

  • Added tests for calc_payout.rs .
  • Added docs for calc_payouts and calc_fee.

TODO:

  • Gather tests in a single file.

@bee344 bee344 requested a review from a team as a code owner August 18, 2023 02:08
TarikGul
TarikGul reviewed Aug 18, 2023
View reviewed changes
calc/README.md Outdated Show resolved Hide resolved
TarikGul
TarikGul reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really amazing so far 👍

TarikGul
TarikGul reviewed Aug 18, 2023
View reviewed changes
calc/src/calc_payout.rs Outdated Show resolved Hide resolved
marshacb
marshacb reviewed Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just 1 nit/question

@bee344 bee344 changed the title [WIP] Add test for calc_payout Add test for calc_payout Aug 18, 2023
@TarikGul TarikGul changed the title Add test for calc_payout test(calc): add test for calc_payout Aug 18, 2023
TarikGul
TarikGul approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job 👍

@bee344 bee344 merged commit b105cd3 into master Aug 18, 2023
3 of 7 checks passed
@bee344 bee344 deleted the anp-test-calc-payout branch August 18, 2023 14:22
@bee344 bee344 mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bee344 @marshacb @TarikGul