feat: improve performance with new version of PJS #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imod7
reviewed
Oct 18, 2024
|
I think the linter is currently failing since the PJS/api version does not include the changes to the provider outlined in the PR |
Imod7
approved these changes
Oct 22, 2024
|
Just to mention for any other reviewers, I approved because:
Same applies for the linter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider injected in the ApiPromise now accepts an optional cache size, which when set to zero will allow PJS to bypass caching on the requests, improving performance and decreasing memory leaks.
TODO: PJS version needs to be patched in package.json
Only merge this with the release of PJS coming in the next week or so (after 17th October 2024, possibly v13.2.2, TBD)