Add endpoints #504
Add endpoints #504
Conversation
src/services/paras/ParasService.ts
Outdated
| * } | ||
| * @param hash `BlockHash` to make call at | ||
| * @param paraId ID of para to get crowdloan info for | ||
| * @returns crowdloan information for paradId |
There was a problem hiding this comment.
I don't think we need this, We don't document any of the @returns in any other services, we could get rid of this. Up to you though.
src/services/paras/ParasService.ts
Outdated
| * } | ||
| * @param hash `BlockHash` to make call at | ||
| * @param includeFundInfo wether or not to include `FundInfo` for every crowdloan | ||
| * @returns list of all crowdloans |
There was a problem hiding this comment.
Same as before. Maybe we could remove these @returns and write doc info above the @param notes.
There was a problem hiding this comment.
I don't think this is really that important more so an observation of continuity between all services.
| @@ -45,51 +71,44 @@ export class ParasService extends AbstractService { | |||
| return { | |||
| at, | |||
| fundInfo, | |||
| // TOOD would it make snese to merge the below derived info into `fundInfo` | |||
There was a problem hiding this comment.
Little confused on this could you elaborate?
There was a problem hiding this comment.
Basically should we add leasePeriods as a key within the fundInfo object?
| blockNumber | ||
| ).toNumber(); | ||
|
|
||
| leasesFormatted = leases.reduce((acc, curLeaseOpt, idx) => { |
| leasesFormatted = null; | ||
| } | ||
|
|
||
| let onboardingAs: ParaType | undefined; |
There was a problem hiding this comment.
Could we make an IOption<T> for undefined's?
There was a problem hiding this comment.
I would be open to it, but would want to call it something else.
My only hold up though are that undefined fn params and interface properties already have the ? operator which is normally preferred over having a union type with undefined.
| blockNumber = number.unwrap(); | ||
|
|
||
| currentLeaseHolders = leaseEntries | ||
| .filter(([_k, leases]) => leases[0].isSome) |
There was a problem hiding this comment.
I like the use of isSome, I think it has the ability to also optimize code in a lot of other service, etc
There was a problem hiding this comment.
Yup - just to clarify though, this is .isSome is a property on the polkadot-js Option enum which extends Codec - which is different than the IOption type alias we have defined within this repo.
|
|
||
| const parasPromises = paraLifecycles.map(async ([k, paraLifeCycle]) => { | ||
| const paraId = k.args[0]; | ||
| let onboardingAs: ParaType | undefined; |
There was a problem hiding this comment.
Same thing here could we have a Option for undefined.
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Adds endpoints:
paras/: list of all registered parachains and their lifecycle stage./:paraId/lease-info: current and future lease information for a para./:paraId/crowdloan-info: info on a para's current crowdloan./leases/current: list of all lease holders for the current lease period and general information about the current lease period./auctions/current: information on the current auction.Future PRs:
crowdloan-info&lease-infointo a single endpoint that just has all the plo info that is specific to a chain.