Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deps, reconfigure tests to reflect most recent polkadot-js changes #584

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

TarikGul
Copy link
Member

This PR updates the deps for polkadot-js, and substrate/dev

I also reconfigured tests in order to reflect the most recent internal changes to polkadot-js here

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I think in general that we should try to be explicit about any numbers that appear in tests. If they are just random numbers or have a meaning, it'd be helpful to see a short comment as a hint of "don't bother wondering where this came from".

@@ -30,7 +30,7 @@ export const PRE_SANITIZED_BALANCE_LOCK = kusamaRegistry.createType(
'Vec<BalanceLock>',
[
{
id: 'LockId',
id: '00000000',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It expected the id to be of 8 bytes but instead lockId is 6 bytes

@dvdplm dvdplm merged commit d12ef6a into master Jun 14, 2021
@dvdplm dvdplm deleted the tarik-update-deps branch June 14, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants