fix: confirm session module before block retrieval #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
requested review from
dvdplm,
maciejhirsz,
jsdw,
insipx and
niklasad1
jsdw
approved these changes
Nov 1, 2021
insipx
reviewed
Nov 1, 2021
| ): Promise<Vec<AccountId32>> { | ||
| return historicApi.query.session | ||
| ? historicApi.query.session.validators() | ||
| : ([] as unknown as Vec<AccountId32>); |
There was a problem hiding this comment.
I think this was brought up before but i forgot; why do we need to cast to unknown before Vec? why not just return []
There was a problem hiding this comment.
So this comes down to the typescript compiler. Basically, the functions expects Vec<AccountId32> to be returned, and when we return [] its of type Array. Now the compiler sees Vec<AccountId32> and notices there is no straight type conversion from Vec<AccountId32> -> Array<any>, therefore it throws a type conversion error (Even though we know the exact output and input for the values). To get around type conversion issue we have to set it to unknown so the typescript compiler sees that the type is convertable.
insipx
approved these changes
Nov 1, 2021
TarikGul
commented
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #743
Updates the blocks endpoint to not fail when the connected chain doesn't have the session module to gather validators.