fix: decode Bytes types for /runtime/metadata correctly
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tarik-metadata-decode
TarikGul
changed the title
Bytes types for /runtime/metadata correctly
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
jsdw
reviewed
Apr 28, 2022
|
Before we merge I am actually going to switch the structure up a bit to accommodate different metadata versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #893
There are certain values given via the metadata that exist as type
BytesorRaw. Since technically the bytes can be any value, we need to find the lookup type definitions and then sanitize them accordingly. To do this I added an options param tosanitizeNumberswhich allows us to specify we are sanitizing metadata, and to pass in a registry in order to correctly build the corresponding types theseBytespoint to then decode them to a correct (a.) JSON value (b.) correct integer.