Add Codespaces to the repository #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Substrate setup of the Codespaces container to an earlier stage that is included in the prebuild process
hummusonrails
requested review from
cmichi,
HCastano,
athei,
ascjones and
agryaznov
as code owners
|
CI fails because we need to sync against the latest substrate release I think. |
|
Yep. Please merge or rebase |
|
Thanks both. I'll go ahead and do that early this coming week. |
Add the wasm32-unknown-unknown target to the stable build as well
Minor improvements including spelling and fixing broken links.
…ech#186) This is needed in order to make the e2e test for [call_runtime](https://github.com/paritytech/ink/blob/e267dd15730c3d19d5030fa440292f849acf9960/integration-tests/call-runtime/lib.rs#L150) pass
… node (paritytech#187) In recent PR paritytech#182 (comment), the CI step of running `cargo test` was commented out as a dirty workaround for the pallet contracts integrity test failure. The test checks that the pallet configuration is memory safe. So to make the test pass, we enlarge the runtime memory limit in the Schedule. We do this because this development node [allows](https://github.com/paritytech/substrate-contracts-node/blob/8d13ddef3f5c728d1661e79c511a28cef206b298/runtime/src/lib.rs#L367) larger contract size than it is normally allowed in a production running node. This should be fine for the development node where possible security implications could be neglected for the sake of development convenience. **However, please DO NOT do this to your production node config, unless you are sure that the limit you're setting is the real memory limit of your runtime**.
To be used in creating the pre-built binary to host on the Docker image
Since it's now fetched from the Docker image this is not needed
|
@athei and @SkymanOne This is now ready for a review again. 🙏🏻 |
mateo-moon
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @kianenigma, @PierreBesson and others, this pull request brings the ability to spin up a Codespace instance inside this repository. The PR has two components:
devContainer.json: The setup instructions to initialize the instance withpostCreateCommand.sh: A custom shell script to install the necessary dependencies for Substrate and the contracts node template on the Codespace instance that is invoked immediately after the instance is createdOnce this is merged, we can then include links for folks to create their own Codespace with the contracts node template using their own GitHub account similar to the way Rustlings does do.