use git polkadot-sdk deps

[pgherveou]

No description provided.

[pgherveou]

I probably need to mark it as publish = false if we decide to keep git ref

[ascjones]

I think it can't be released anyway with the git refs, but yes I think we had this before

[ascjones]

All git deps should be more spcific

[ascjones]

I think it can't be released anyway with the git refs, but yes I think we had this before

[pgherveou]

You mean we should use a tag? Isn't relying on the lock file more convenient to update to newer version of the code?

[ascjones]

You mean we should use a tag? Isn't relying on the lock file more convenient to update to newer version of the code?

Better to be explicit, we can't guarantee someone will install using --locked. It's easy enough do do a search/replace with branch = "" We used to track the polkadot-* branches. I see there is now e.g. https://github.com/paritytech/polkadot-sdk/tree/release-polkadot-v1.2.0

[pgherveou]

Sounds good will do that. Thanks for the feedback Andrew

[pgherveou]

@ascjones updated to use branch = "release-polkadot-v1.2.0" everywhere

[ascjones]

LGTM, though we must remember to switch back to crates.io dependencies as soon as they are available.

[pgherveou]

I should probably use this branch to check that ink e2e tests are still passing before merging right? Anything else you do usually ?

[ascjones]

I should probably use this branch to check that ink e2e tests are still passing before merging right? Anything else you do usually ?

Yes that's a good idea to do that, you can either do that here or as part releasing the next version with these changes.

[pgherveou]

found some issues with transfer that has to be renamed to transfer_allow_death in ink e2e test.
Will merge this and push a PR to ink