Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591

jsdw · 2024-08-29T16:24:07Z

This builds on #587 and addresses a couple of nits:

Hide new oclumns by default; they take up too much space
Default to showing '-' in new columns when no data is available.

When I tested this locally, I saw no data for a bunch of the new columns and need to understand why that is before merging.

Added new item in Ranking node_map, mapping node id to node detail Co-authored-by: Cyndie Kamau <cyndiekamaa@gmail.com>

…a folder

CyndieKamau · 2024-08-29T18:02:14Z

Hey @jsdw I can answer that for you.

So when setting up a local dev node, depending on the type of OS for your machine then the output is different.

For instance, in macOS you can only see around 3 data columns, but for Linux all the columns are filled. This is something I also noted down and informed @bLd75 about.

So this setup was configured to collect more information from a linux environment than macos, so the telemetry server will get more details from linux than macos.

So to confirm everything was working we had to test on a linux environment.

MrishoLukamba · 2024-08-29T18:02:35Z

This builds on #587 and addresses a couple of nits:

Hide new oclumns by default; they take up too much space

Default to showing '-' in new columns when no data is available.

When I tested this locally, I saw no data for a bunch of the new columns and need to understand why that is before merging.

We did it in a way that you have to toggle to actually display new columns. So by default they are hidden

jsdw · 2024-08-30T08:55:41Z

We did it in a way that you have to toggle to actually display new columns. So by default they are hidden

If you have already edited the telemetry settings, they are saved in localStorage and so it might be that that was the case for you, and so adding new things were hidden.

When I tested it, I had no settings saved and so they all showed up by default (see https://github.com/paritytech/substrate-telemetry/pull/591/files#diff-e56cb91573ddb6a97ecd071925fe26504bb5a65f921dc64c63e534162950e1ebR73-R83 where I set them to false by default)

jsdw · 2024-08-30T08:58:08Z

So to confirm everything was working we had to test on a linux environment.

Ah, thankyou for this! I'll point a linux based node to it when I'm back home and have my linux laptop to hand :)

MrishoLukamba · 2024-09-16T23:25:58Z

So to confirm everything was working we had to test on a linux environment.

Ah, thankyou for this! I'll point a linux based node to it when I'm back home and have my linux laptop to hand :)

any updates on this, as it is ready to be merged @jsdw

jsdw · 2024-09-17T08:26:17Z

Sorry; this fell off my radar again! We'll aim to get it reviewed and, if all is well testing a linux node pointing to it, merged, in the coming days!

niklasad1 · 2024-09-20T13:52:49Z

frontend/src/components/List/Column/LinuxDistroColumn.tsx

+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+//Column for specifying type of distro each node is running (Linux Distribution)


Suggested change

//Column for specifying type of distro each node is running (Linux Distribution)

// Column for specifying type of distro each node is running (Linux Distribution)

niklasad1 · 2024-09-20T13:53:08Z

frontend/src/components/List/Column/LinuxKernelColumn.tsx

+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+//Column for specifying which kernel each node is running on


Suggested change

//Column for specifying which kernel each node is running on

// Column for specifying which kernel each node is running on

frontend/src/common/types.ts

pkhry · 2024-09-23T08:23:31Z

frontend/src/components/List/Column/VersionColumn.tsx

+  public static readonly label = 'version';
+  public static readonly icon = icon;
+  public static readonly width = 154;
+  public static readonly setting = 'version';


Not used anywhere?

pkhry · 2024-09-23T08:24:22Z

frontend/src/components/List/Column/index.ts

@@ -33,3 +33,12 @@ export * from './BlockTimeColumn';
 export * from './BlockPropagationColumn';
 export * from './LastBlockColumn';
 export * from './UptimeColumn';
+export * from './CpuArchitectureColumn'; //extra columns added


Dq: but given new column follow the same structure and same pattern, can't they be factored out into one?

Yeah I'm sure we could simplify this stuff a bunch!

But I think that shouldnt be the scope of this PR

pkhry · 2024-09-23T08:25:08Z

frontend/src/state.ts

+      target_os,
+      target_arch,
+      target_env,
+      customNullField,


OK, so this is the reason for undefined earlier?

MrishoLukamba · 2024-09-24T20:58:07Z

wen merge? @jsdw @niklasad1 @pkhry

jsdw · 2024-09-25T13:01:54Z

Merged :)

CyndieKamau · 2024-09-25T13:17:47Z

Yay! Thank you @jsdw @niklasad1 @pkhry for the reviews! :)

CyndieKamau · 2024-09-25T13:18:29Z

@jsdw I think we can safely close the first PR yes? It's still open

jsdw · 2024-09-26T11:30:33Z

Yup; FYI I have just deployed this to live, so the new columns are now available on telemetry.polkadot.io.

Thanks for the contribution guys; nice work!

bLd75 · 2024-09-26T12:01:58Z

Great job here, very useful infos added on nodes!
Just a remark: when adding several fields, names get truncated a lot in the list.
It seems the table was designed for a max size and name is the only adjustable column, it would be great if it was scrollable horizontally and keep full columns length.

jsdw · 2024-09-26T15:01:00Z

Yup, and scrolling to the right is naff too; I added #592 for this!

MrishoLukamba and others added 11 commits August 26, 2024 14:37

added functionality for specifying node details per each node

6cd6b0e

Backend done

30c9081

Added new item in Ranking node_map, mapping node id to node detail Co-authored-by: Cyndie Kamau <cyndiekamaa@gmail.com>

feat: last frontend working version

efd4ef6

chore: Clean up unused code

276fa60

fix(frontend): update node details to carry 10 fields

7ae78ff

chore: remove unnecessary code

8071a3d

chore: run cargo fmt for formatting

3dfb3da

chore: run prettier to format frontend

50d3a74

fixed e2e tests added missing struct params

aecd20b

remoted .idea file

c69e044

Hide new columns by default, default to - if no data, and remove .ide…

7805fe1

…a folder

jsdw mentioned this pull request Aug 29, 2024

Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #587

Closed

niklasad1 reviewed Sep 20, 2024

View reviewed changes

niklasad1 approved these changes Sep 20, 2024

View reviewed changes

pkhry reviewed Sep 23, 2024

View reviewed changes

frontend/src/common/types.ts Show resolved Hide resolved

pkhry reviewed Sep 23, 2024

View reviewed changes

pkhry approved these changes Sep 23, 2024

View reviewed changes

jsdw merged commit 0cd8726 into master Sep 25, 2024
9 checks passed

jsdw deleted the pr-587 branch September 25, 2024 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591

Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591

jsdw commented Aug 29, 2024

CyndieKamau commented Aug 29, 2024

MrishoLukamba commented Aug 29, 2024

jsdw commented Aug 30, 2024 •

edited

Loading

jsdw commented Aug 30, 2024

MrishoLukamba commented Sep 16, 2024 •

edited

Loading

jsdw commented Sep 17, 2024

niklasad1 Sep 20, 2024

niklasad1 Sep 20, 2024

pkhry Sep 23, 2024

pkhry Sep 23, 2024

jsdw Sep 23, 2024

MrishoLukamba Sep 23, 2024

jsdw Sep 23, 2024

pkhry Sep 23, 2024

MrishoLukamba Sep 23, 2024

MrishoLukamba commented Sep 24, 2024

jsdw commented Sep 25, 2024

CyndieKamau commented Sep 25, 2024

CyndieKamau commented Sep 25, 2024

jsdw commented Sep 26, 2024

bLd75 commented Sep 26, 2024

jsdw commented Sep 26, 2024

	//Column for specifying type of distro each node is running (Linux Distribution)
	// Column for specifying type of distro each node is running (Linux Distribution)

	//Column for specifying which kernel each node is running on
	// Column for specifying which kernel each node is running on

Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591

Feat: Map Node Stats (Version, Operating System etc) to each Node in Feed #591

Conversation

jsdw commented Aug 29, 2024

CyndieKamau commented Aug 29, 2024

MrishoLukamba commented Aug 29, 2024

jsdw commented Aug 30, 2024 • edited Loading

jsdw commented Aug 30, 2024

MrishoLukamba commented Sep 16, 2024 • edited Loading

jsdw commented Sep 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrishoLukamba commented Sep 24, 2024

jsdw commented Sep 25, 2024

CyndieKamau commented Sep 25, 2024

CyndieKamau commented Sep 25, 2024

jsdw commented Sep 26, 2024

bLd75 commented Sep 26, 2024

jsdw commented Sep 26, 2024

jsdw commented Aug 30, 2024 •

edited

Loading

MrishoLukamba commented Sep 16, 2024 •

edited

Loading