[ci] Migrate CI from GitLab to GitHub #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutantcornholio
approved these changes
Oct 29, 2024
| paths: | ||
| - ".github/workflows/backend*" | ||
| - "backend/**" | ||
| - "!frontend/**" |
There was a problem hiding this comment.
Is there a reason to exclude frontend? These paths shouldn't collide, right?
There was a problem hiding this comment.
Not sure that there is a reason, it was done previously and I only copy-pasted this part.
There was a problem hiding this comment.
I would guess that the reason is so that PRs which make only frontend changes don't need to trigger any sort of backend related CI jobs.
There was a problem hiding this comment.
@mutantcornholio meant that "backend/**" should be already enough to trigger backend workflow only for changes in backend path and "!frontend/**" might be redundant.
There was a problem hiding this comment.
Oh I see! Yeah maybe it was just being extra sure or something then :D
AndWeHaveAPlan
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
United 4 backend workflows into one because now each job has its own cache and there is no need to divide them into separate workflows (was done here).
cc https://github.com/paritytech/ci_cd/issues/1053