Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Implement Lockable for Assets (for use in e.g. vesting or voting systems) #11446

Open
hbulgarini opened this issue May 18, 2022 · 3 comments
Open
Labels
J0-enhancement An additional feature request.

Comments

@hbulgarini
Copy link
Contributor

An interesting feature for chains using the assets pallet is the chance to vest those assets, similar to what is possible now with DOT and KSM on their respective relay chains. 

I can think of multiple use cases on Statemint/e for teams deploying their assets on these chains and extending their possibilities around their launch strategy.

The functionality can be implemented on the same assets pallet  or modify the vesting pallet to accept different assets ( or a complete new pallet ). Whatever it is makes the implementation simpler and safer.

CC: @joepetrowski @shawntabrizi

@hbulgarini hbulgarini added the J0-enhancement An additional feature request. label May 18, 2022
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label May 18, 2022
@joepetrowski joepetrowski removed the J2-unconfirmed Issue might be valid, but it’s not yet known. label Nov 10, 2022
@joepetrowski joepetrowski changed the title Vesting feature for assets. Implement Lockable for Assets (for use in e.g. vesting or voting systems) Nov 10, 2022
@joepetrowski
Copy link
Contributor

Part of paritytech/polkadot-sdk#327 and a highly requested feature for assets on Statemint.

@tonyalaribe
Copy link
Contributor

tonyalaribe commented Nov 16, 2022

For clarity, does this refer to the LockableCurrency trait? https://docs.rs/frame-support/latest/frame_support/traits/trait.LockableCurrency.html

Or as the task to introduce a new trait as mentioned in paritytech/polkadot-sdk#327 :

Introduce fungibles::Lockable/fungible::Lockable and implement for Balances and AssetsFreezer.
Introduce LockableAssets derivative pallet and implement fungibles::Lock.

@joepetrowski
Copy link
Contributor

AFAIU the goal is to introduce a new trait and then migrate pallets to it, eventually deprecating the Currency traits:

  • Swtich over trait requirements from Currency to fungible::* in pallets.

I'm not sure off the top of my head if fungible::Lockable should have the same API as LockableCurrency though. Can @gavofyork confirm?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

3 participants