Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens Horizon #327

Open
8 of 20 tasks
gavofyork opened this issue Mar 25, 2021 · 12 comments
Open
8 of 20 tasks

Tokens Horizon #327

gavofyork opened this issue Mar 25, 2021 · 12 comments
Assignees
Labels
I6-meta A specific issue for grouping tasks or bugs of a specific category. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@gavofyork
Copy link
Member

gavofyork commented Mar 25, 2021

FTs:

NFTs:

Associated paritytech/substrate#8285

@olanod
Copy link
Contributor

olanod commented Mar 29, 2021

Perhaps something for the TODO list and more of a question to hear some ideas, would it make sense to make the Assets pallet instantiable? My motivation is, first that it doesn't harm and second that it makes working with unrelated groups of assets a bit more convenient and conceptually more correct, if I have a pallet depending on some fungibles::* that have something in common and are a subset of the potentially bigger set that the one Assets instance will store I often need some extra config in my pallet to be able to filter out assets from that bigger set. With different instances of Assets I relax more and trust the pallet will be configured with right subset of assets and just rely on the type system to do the "filtering" at compile time instead. I imagine I could also query the asset to see if it comes with some label or something in its T::Extra data but also seems like extra work.

@gavofyork
Copy link
Member Author

I would accept a PR that did it, but the other items on the list are somewhat more pressing.

@olanod
Copy link
Contributor

olanod commented Apr 5, 2021

PR is there in case you feel like giving it a quick look in a coffee/bubble tea break 😉 paritytech/substrate#8483

@chrisdcosta
Copy link

Can this new token stuff be optional for chains that don't want or need multi-currency support? It seems to be baked in - unless I'm missing something?

@gavofyork
Copy link
Member Author

All multi-currency stuff will continue to be completely optional.

@danforbes
Copy link

I'm curious about the thoughts/plans that exist around non-fungible token standards and would like to offer my contributions if they can be of help. I am the author of a pallet that defines and implements a UniqueAssets trait and have also worked with the ORML NFT pallet. I would like to start by creating some specifications around the key/value pairs that may exist as attributes on an NFT. What are the expectations that exist around the presence of certain attributes, the values they may take, and how those values impact the presence of other attributes and their possible values? I think it would be productive to follow an approach that is similar to/inspired by the OpenAPI (nee Swagger) specification.

@pmensik
Copy link
Contributor

pmensik commented Apr 21, 2021

I am actually really interested in this initiative as well since we are about to start the development of a generic auction pallet for different NFT implementations (we have already delivered PoC on top of the orml-nft). So I wonder which NFT implementation is gaining the most traction at the moment and what can we do to help the standardization process within Polkadot/Kusama ecosystem. We have created our own tracking issue inside the project so definitely appreciate any of your thoughts!

@Swader
Copy link

Swader commented May 5, 2021

I would also like to participate in the NFT specification in some way, given that RMRK (which has picked up considerable steam) is, functionality-wise, far more advanced that typical NFTs are (we have nested NFTs, on-chain emotes as price discovery and signal, reactive NFTs with conditional rendering, equip mechanics, and NFTs being governed as DAOs). If we can help somehow or contribute to the discussions around speccing all this out, we'd love to.

@iorveth
Copy link

iorveth commented Jun 25, 2021

I spotted a couple of potential issues/areas of improvement for nonfungible(s) traits and uniques pallet.
Let me know if you are interested in further contributions, please
paritytech/substrate#9208,
paritytech/substrate#9207,
paritytech/substrate#9211,
paritytech/substrate#9206

@kinosang
Copy link

do we really need a AssetsFreezer pallet? could we just implement fungibles::Hold in assets pallet?

@flipchan
Copy link

It would be really nice to get a freeze function that can freeze X amount of a certain asset's. Similar to how it's doable with "T::Currency::freeze(AccountId, Balance)?".
I am currently manually implementing this in the LLM pallet(the freeze X amount of a certain asset, where the use case is that asset's work similar to tokens) at https://github.com/liberland/liberland_substrate . It would be great to have this built into the asset pallet, as this can then be expanded and it will allow implementations such as: Voting using pallet-democracy and the chain holding the on-chain asset's to vote with the onchain asset's instead of what's currently just a T::Currencyfreeze with pallet democracy.

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/statemint-update-roadmap/1200/1

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I6-meta A specific issue for grouping tasks or bugs of a specific category. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed J1-meta labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/gettalong/kramdown/releases)
- [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page)
- [Commits](https://github.com/gettalong/kramdown/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I6-meta A specific issue for grouping tasks or bugs of a specific category. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
Development

No branches or pull requests