Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename Hashing trait to Hash #172

Closed
rphmeier opened this issue May 24, 2018 · 0 comments · Fixed by #288
Closed

Rename Hashing trait to Hash #172

rphmeier opened this issue May 24, 2018 · 0 comments · Fixed by #288
Assignees
Labels
I7-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

as it's more idiomatic

paritytech/polkadot#169 (comment)

@rphmeier rphmeier added the I7-refactor Code needs refactoring. label May 24, 2018
@simonljs simonljs self-assigned this Jul 2, 2018
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
* Integrates new gossip system into Polkadot (paritytech#166)

* new gossip validation in network

* integrate new gossip into service

* Fix build

* Fix claims module

* fix warning

* update to latest master again

* update runtime
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this issue Apr 21, 2021
liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
* rm wasm src

* change wasm

* wasm comile err finish
liuchengxu added a commit to autonomys/substrate that referenced this issue Jun 3, 2022
* Add polkadot#c87a220490f88dfee0d5602fd834f4801916b269

* Remove unnecessary subsystems from origin polkadot overseer

* Remove ParachainHost and BabeApi from RuntimeApiSubsystem

* Remove AuthorityDiscovery from NetworkBridgeSubsystem

* Integrate the overseer into subspace node

In order to integrate the polkadot overseer, we need to firstly replace
some polkadot primitives used in the subsystems with subspace
primitives. With this commit, the executor node attempts to produce a
candidate on each new primary block.

* Add pallet-executor and sp-executor into subspace node

`pallet-executor` provides an unsigned extrinsic which will used be to
submit the candite receipt from the embedded subspace node later.

* Coordinate the collation generation in overseer to keep executor chain running

The main flow of collation generation in overseer:

1. On each tip of primary chain, a collation generation will be requested, with
   the current pending head of executor chain sent in `PersistedValidatonData`.

2. Once the collation is received, process the collation and then send it to
  RuntimeApiSubsystem, invoking the runtime api `submit_candidate_receipt_unsigned` to
  submit the executor block hash to the primary chain.

* Move cumulus into subspace

To run a demo locally:

```bash
$ cargo build --release --bin parachain-collator
$ cargo build --release --bin subspace-farmer
$ cargo build --release --bin subspace-node

$ rm -rf s && ./target/release/subspace-node --dev -d s --log=sync=trace,parachain=trace,txpool=trace

./target/release/subspace-farmer erase-plot && ./target/release/subspace-farmer farm

./start_executor.sh
```

* Use relative local path in cumulus deps

* Fix parachain stalled at #2

The root cause is that the parachain chain block production and import
are performed **concurrently**, but the correct block import is order
sensitive, which means the executor node can't produce next candidate
until the current candiate has been imported, otherwise it'll produce
multiple candidates at the same height. This implies that the logic
around `check_block_status` is crucial.

* Use local polkadot deps in cumulus

* Fix the compile of custom Block abstraction against overseer

* Drop network bridge subsystem from overseer

* Drop collation protocol from overseer and polkadot node network protocol from node

* Remove unused deps in polkadot overseer

* Remove cumulus_pallet_parachain_system from parachain-template

* Remove `cumulus-primitives-core` from parachain template

* Clean up parachain-template/node

* Clean up cirrus/consensus

* Clean up cirrus-service

* Remove cumulus primitives

* Remove cirrus-network

* Remove unused subsystems in polkadot/node/core

* More cleanup on overseer

* Fix the compile warnings

Partial of them are supressed by `allow(unused)`.

* Clean up subsystem-util and subsystem-types

* Remove polkadot deps from overseer-gen

* Remove polkadot-primitives from runtim-api and chain-api

* Remove a bunch of obviously unused polkadot deps

* Remove more polkadot deps

* Remove polkadot-parachain

* Remove polkadot-core-primitives

* Remove polkadot-primitives

* Remove polkadot-node-primitives

* Remove subsystem-test-helpers

* More cleanups on cumulus

* Remove HeadSupportParachains trait

* cargo fmt --all

* Clean up subspace-node and pallet-executor

* Remove overseer-gen examples

* Remove cumulus consensus common tests

* Fix cargo test

* Fix cargo clippy

* More tweaks

* Move `service/mod.rs` back to `service.rs` for consistency with the rest of the codebase

* Tiny simplification by making `service::new_full()` async

* Cleaner `command::run()`

* Remove `IsCollator` as it is unused anyway

* Simplify overseer creation

* Remove unnecessary node dependencies

* Inline overseer creation and remove one more node dependency

* Revert `subspace-runtime-primitives` changes and move code to `subspace-node-primitives` as it is only needed there

* Rename `subspace-node-primitives` to `cirrus-node-primitives` since that is the only place it is used

* Remove one more unnecessary node dependency

* Combine imports

Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
helin6 pushed a commit to boolnetwork/substrate that referenced this issue Jul 25, 2023
This is needed for Ledgeracio, as Ledgeracio’s signer is now no longer
`Send`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants