This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Offchain-worker: Make it possible to disable http support #10087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a chain doesn't require http support in its offchain workers, this pr enables them to disable the http support.
bkchr
added
A0-please_review
tomusdrw
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
looks good, but we already have capabilities filtering though, so this adds yet another layer to the setup. I understand that we want to avoid starting the shared http client, but just pointing out that this a bit of a workaround.
Have you considered compilation features instead? It would be perfectly fine to leave http requests enabled and just disable https from the shared client.
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
|
@tomusdrw I now switched to the |
…ubstrate into bkchr-offchain-disable-http
bkchr
added
the
D3-trivial 🧸
andresilva
approved these changes
Oct 26, 2021
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…#10087) * Offchain-worker: Make it possible to disable http support If a chain doesn't require http support in its offchain workers, this pr enables them to disable the http support. * Switch to bitflags * Use Capabilities * Update client/offchain/src/lib.rs Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com> * Fix test * Update client/offchain/src/lib.rs Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…#10087) * Offchain-worker: Make it possible to disable http support If a chain doesn't require http support in its offchain workers, this pr enables them to disable the http support. * Switch to bitflags * Use Capabilities * Update client/offchain/src/lib.rs Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com> * Fix test * Update client/offchain/src/lib.rs Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com> Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chain doesn't require http support in its offchain workers, this pr enables them to disable the
http support.
Closes: #9984