Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove unnecessary allocations when crossing WASM FFI boundary #10191

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Remove unnecessary allocations when crossing WASM FFI boundary #10191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions primitives/runtime-interface/src/impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,8 @@ macro_rules! impl_traits_for_arrays {
type SelfInstance = [u8; $n];

fn from_ffi_value(context: &mut dyn FunctionContext, arg: u32) -> Result<[u8; $n]> {
let data = context.read_memory(Pointer::new(arg), $n)?;
let mut res = [0u8; $n];
res.copy_from_slice(&data);
context.read_memory_into(Pointer::new(arg), &mut res)?;
gilescope marked this conversation as resolved.
Show resolved Hide resolved
Ok(res)
}
}
Expand Down Expand Up @@ -514,10 +513,8 @@ macro_rules! for_u128_i128 {
type SelfInstance = $type;

fn from_ffi_value(context: &mut dyn FunctionContext, arg: u32) -> Result<$type> {
let data =
context.read_memory(Pointer::new(arg), mem::size_of::<$type>() as u32)?;
let mut res = [0u8; mem::size_of::<$type>()];
res.copy_from_slice(&data);
context.read_memory_into(Pointer::new(arg), &mut res)?;
Ok(<$type>::from_le_bytes(res))
}
}
Expand Down