Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Cli: Introduce --detailed-log-output flag #10278

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Nov 16, 2021

If this CLI flag is given, detailed log output will be enabled. This includes the log level, log
target ad the thread name. Before this was only enabled when a log level higher than info should
be logged.

If this CLI flag is given, detailed log output will be enabled. This includes the log level, log
target ad the thread name. Before this was only enabled when a log level higher than `info` should
be logged.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 16, 2021
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

The only concern I have is whether we should make the "detailed" output the default everywhere for everyone. In other words: is there any point in having the "pretty" default style we have now?

client/tracing/src/logging/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: David <dvdplm@gmail.com>
@bkchr
Copy link
Member Author

bkchr commented Nov 16, 2021

lgtm.

The only concern I have is whether we should make the "detailed" output the default everywhere for everyone. In other words: is there any point in having the "pretty" default style we have now?

Normal node operators probably do not care and it also reduces the amount of data being outputted?

@bkchr bkchr merged commit f846ee0 into master Nov 16, 2021
@bkchr bkchr deleted the bkchr-cli-introduce-detailed-output branch November 16, 2021 13:01
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Cli: Introduce `--detailed-log-output` flag

If this CLI flag is given, detailed log output will be enabled. This includes the log level, log
target ad the thread name. Before this was only enabled when a log level higher than `info` should
be logged.

* Update client/tracing/src/logging/mod.rs

Co-authored-by: David <dvdplm@gmail.com>

Co-authored-by: David <dvdplm@gmail.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Cli: Introduce `--detailed-log-output` flag

If this CLI flag is given, detailed log output will be enabled. This includes the log level, log
target ad the thread name. Before this was only enabled when a log level higher than `info` should
be logged.

* Update client/tracing/src/logging/mod.rs

Co-authored-by: David <dvdplm@gmail.com>

Co-authored-by: David <dvdplm@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants