Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add vote and seconded events to Democracy pallet. #10352

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff commented Nov 23, 2021

Closes #10283

This PR adds two new events to pallet democracy, Seconded for when a user seconds a proposal. And Voted for when a user votes on a referendum.

Question about the Polkadot: This only adds the events to the pallet. It does not require any code changes in Polkadot. Shall I still open a Polkadot PR that updates its cargo.lock file? If so shall I wait until this is merged so I know what sha to point to?

cc @thiolliere

bin/node/runtime/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from gui1117 November 24, 2021 09:23
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 24, 2021
@kianenigma kianenigma changed the title add the events Add vote and seconded events to Democracy pallet. Nov 26, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@gui1117
Copy link
Contributor

gui1117 commented Nov 29, 2021

I don't know why CI is not happy, maybe merge master ?

@kianenigma kianenigma added A1-onice and removed A0-please_review Pull request needs code review. labels Nov 30, 2021
@bkchr bkchr added A0-please_review Pull request needs code review. and removed A1-onice labels Nov 30, 2021
@bkchr bkchr merged commit 270fac3 into paritytech:master Nov 30, 2021
JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this pull request Dec 1, 2021
* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
(cherry picked from commit 270fac3)
JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this pull request Dec 1, 2021
…) (#23)

* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
(cherry picked from commit 270fac3)
niklasad1 added a commit that referenced this pull request Dec 2, 2021
tgmichel added a commit to moonbeam-foundation/substrate that referenced this pull request Dec 3, 2021
…) (#23)

* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
(cherry picked from commit 270fac3)

(cherry picked from commit f0d3cd3)
tgmichel added a commit to moonbeam-foundation/substrate that referenced this pull request Jan 10, 2022
…) (#23)

* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
(cherry picked from commit 270fac3)

(cherry picked from commit f0d3cd3)
(cherry picked from commit 24a1737)
tgmichel added a commit to moonbeam-foundation/substrate that referenced this pull request Jan 18, 2022
…) (#23)

* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
(cherry picked from commit 270fac3)

(cherry picked from commit f0d3cd3)
(cherry picked from commit 24a1737)
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are there no events for Seconded and Voted in pallet democracy
5 participants