This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Clean up pallet-contracts documentation
#10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
cmichi
reviewed
Dec 7, 2021
| The documentation of all importable functions can be found | ||
| [here](https://github.com/paritytech/substrate/blob/master/frame/contracts/src/wasm/runtime.rs). | ||
| Look for the `define_env!` macro invocation. | ||
|
|
There was a problem hiding this comment.
Hey nice! I like that you added this section!
cmichi
approved these changes
Dec 7, 2021
cmichi
approved these changes
Dec 7, 2021
ascjones
approved these changes
Dec 7, 2021
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Update CHANGELOG.md * Remove COMPLEXITY.md
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Update CHANGELOG.md * Remove COMPLEXITY.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the changelog and remove
COMPLEXITY.md. We no longer need to manually document the complexity of host functions because it is all covered by benchmarks now and we implicitly assume that all complexity is at most linear. Otherwise the benchmarks would report large errors since they aren't able to use linear regression to determine weight factors. The file was mainly duplication of documentation and horribly outdated.