Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chain-spec: Make chain spec writing deterministic #10550

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 23, 2021

This switches the chain spec to use BTreeMap internally instead of HashMap. This ensures that
reading and writing the same chain spec always results in the same file.

This switches the chain spec to use `BTreeMap` internally instead of `HashMap`. This ensures that
reading and writing the same chain spec always results in the same file.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 23, 2021
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkchr
Copy link
Member Author

bkchr commented Dec 23, 2021

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit 026ec33 into master Dec 23, 2021
@paritytech-processbot paritytech-processbot bot deleted the bkchr-chain-spec-deterministic branch December 23, 2021 17:45
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* chain-spec: Make chain spec writing deterministic

This switches the chain spec to use `BTreeMap` internally instead of `HashMap`. This ensures that
reading and writing the same chain spec always results in the same file.

* fmt
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* chain-spec: Make chain spec writing deterministic

This switches the chain spec to use `BTreeMap` internally instead of `HashMap`. This ensures that
reading and writing the same chain spec always results in the same file.

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants