This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Enrich the sync log on handling the block request #11747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more info to the log to help debug the issue like https://github.com/paritytech/substrate/issues/11732.
bkchr
reviewed
Jun 28, 2022
|
|
||
| debug!( | ||
| target: LOG_TARGET, | ||
| "Sending result of block request from {peer} starting at `{from_block_id:?}`: \ |
There was a problem hiding this comment.
This should be put into the if branch? Because we don't send any block response in the None case? We can instead add a second logging that says that we don't send any response.
There was a problem hiding this comment.
Hmm, actually we still send a response in terms of the OutgoingResponse below, which contains a result Err(()) in the case of None. blocks will be displayed as Some(100) or None which indicates we send 100 blocks or we don't send back any blocks, should be clear enough for the diagnostic purpose IMO.
arkpar
approved these changes
Jun 30, 2022
bkchr
added
A0-please_review
bkchr
approved these changes
Jul 18, 2022
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 32e36c9 |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
Add more info to the log to help debug the issue like https://github.com/paritytech/substrate/issues/11732. Co-authored-by: Bastian Köcher <info@kchr.de>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Add more info to the log to help debug the issue like https://github.com/paritytech/substrate/issues/11732. Co-authored-by: Bastian Köcher <info@kchr.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more info to the sync log to help debug the issue like
paritytech/polkadot-sdk#531.
cc @arkpar