Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

remove FunctionOf #11897

Merged
merged 3 commits into from
Jul 25, 2022
Merged

remove FunctionOf #11897

merged 3 commits into from
Jul 25, 2022

Conversation

kianenigma
Copy link
Contributor

This has already been deprecated since substrate 2.0.0

@kianenigma kianenigma requested review from bkchr and ggwpez July 24, 2022 15:21
@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jul 24, 2022
@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 24, 2022
@kianenigma kianenigma marked this pull request as ready for review July 25, 2022 08:21
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Checks failed for e162eec

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI keeps failing with 'draft' status?!

@kianenigma
Copy link
Contributor Author

CI is drunk again on a monday morning.

@bkchr
Copy link
Member

bkchr commented Jul 25, 2022

CI is drunk again on a monday morning.

But there is still some usage of FunctionOf :P Or the CI is ultra drunk

@kianenigma
Copy link
Contributor Author

CI is drunk again on a monday morning.

But there is still some usage of FunctionOf :P Or the CI is ultra drunk

Both CI and and I drunk 🧠

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 955eda5

@kianenigma
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit eefb4fa into master Jul 25, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-function-of branch July 25, 2022 15:20
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* remove FunctionOf

* fix docs

Co-authored-by: parity-processbot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* remove FunctionOf

* fix docs

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants