This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pruned duplicated dependencies #11900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
kianenigma
reviewed
Jul 25, 2022
| @@ -499,7 +499,7 @@ impl TraitPair for Pair { | |||
| impl Pair { | |||
| /// Get the seed for this key. | |||
| pub fn seed(&self) -> Seed { | |||
| self.secret.serialize_secret() | |||
| self.secret.secret_bytes() | |||
There was a problem hiding this comment.
it's a breaking change of secp256k1 api
kianenigma
approved these changes
Jul 25, 2022
ggwpez
approved these changes
Jul 25, 2022
ggwpez
added
A0-please_review
|
@koushiro please merge master to make the regression benchmark job work. |
bkchr
approved these changes
Jul 25, 2022
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#5808 |
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#5808 |
|
bot merge |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* Update comfy-table v5.0.1 => v6.0.0 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update strum v0.23.0 => v0.24.1 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update h2 v0.3.9 => v0.3.13 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update file-per-thread-logger v0.1.4 => v0.1.5 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update mio v0.8.0 => v0.8.4 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * revert twox-hash Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update secp256k1 v0.21.2 => v0.24.0 Signed-off-by: koushiro <koushiro.cqx@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Update comfy-table v5.0.1 => v6.0.0 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update strum v0.23.0 => v0.24.1 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update h2 v0.3.9 => v0.3.13 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update file-per-thread-logger v0.1.4 => v0.1.5 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update mio v0.8.0 => v0.8.4 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * revert twox-hash Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Update secp256k1 v0.21.2 => v0.24.0 Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update some dependencies to pruned duplicated dependencies
comfy-tablev0.5.1 => v6.0.0strumv0.23.0 => v0.24.1h2v0.3.9 => v0.3.13file-per-thread-loggerv0.1.4 => v0.1.5miov0.8.0 => v0.8.4secp256k1v0.21.2 => v0.24.0polkadot companion: paritytech/polkadot#5808