This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transactional: Wrap
pallet::calls
directly in storage layers #11927transactional: Wrap
pallet::calls
directly in storage layers #11927Changes from 8 commits
0fd5b85
028cf63
d80af32
ab7fa66
f24d062
fe15f9d
9a82ad5
b6095fd
ad18fa6
cec575f
7f400d1
1807e1d
22e5fab
e3bd7c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there no post dispatch weight correction anymore?
Again in line 748
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You change the logic of an extrinsic to be wrapped inside a
with_storage_layer
here?So we now have the invariant that the logic inside an extrinsic is always transactional, no matter how its called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the idea, if you are thinking of making it configurable, there is this PR that attempts to solve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should make it configurable eventually