Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

offences: make fn slash_fraction non-static #11956

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

ordian
Copy link
Member

@ordian ordian commented Aug 1, 2022

A use-case for this is to be able to have slash_fraction parameters derived from runtime configuration and read this config once and in the right context: paritytech/polkadot#5535 (comment).

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 1, 2022
@ordian ordian requested a review from kianenigma August 1, 2022 16:47
@ordian ordian requested a review from andresilva as a code owner August 1, 2022 16:47
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 1, 2022
@ordian ordian added D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 1, 2022
frame/babe/src/equivocation.rs Outdated Show resolved Hide resolved
frame/grandpa/src/equivocation.rs Outdated Show resolved Hide resolved
frame/im-online/src/lib.rs Outdated Show resolved Hide resolved
frame/offences/src/mock.rs Outdated Show resolved Hide resolved
@ordian
Copy link
Member Author

ordian commented Aug 2, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 862dbbc into master Aug 2, 2022
@paritytech-processbot paritytech-processbot bot deleted the ao-make-slash-fraction-non-static branch August 2, 2022 18:49
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* offences: make fn slash_fraction non-static

* Bastifmt (inline variable)
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* offences: make fn slash_fraction non-static

* Bastifmt (inline variable)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants