Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Make chain extension state types public #12032

Merged
merged 1 commit into from
Aug 17, 2022
Merged

contracts: Make chain extension state types public #12032

merged 1 commit into from
Aug 17, 2022

Conversation

athei
Copy link
Member

@athei athei commented Aug 15, 2022

Downstream code sometimes need to name those state types in order to write code that is generic over those states. Hence we make them public but introduce a new Sealed trait to prevent downstream code from implementing those state traits for their own types.

cc @xgreenx

@athei athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Aug 15, 2022
xgreenx
xgreenx approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good=)

@HCastano
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e7aa858 into master Aug 17, 2022
@paritytech-processbot paritytech-processbot bot deleted the at/sealed-chainextension branch August 17, 2022 18:19
@HCastano HCastano mentioned this pull request Aug 30, 2022
Merged
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@athei @ark0f
Make state types public (paritytech#12032)
1a2eb58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascjones ascjones ascjones approved these changes

@HCastano HCastano HCastano approved these changes

@xgreenx xgreenx xgreenx approved these changes

@cmichi cmichi Awaiting requested review from cmichi

@agryaznov agryaznov Awaiting requested review from agryaznov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
Smart Contracts
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@athei @HCastano @ascjones @xgreenx