This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert "Auto-incremental CollectionId" #12059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d8e5a1.
ggwpez
added
A6-revertrevert
C1-low
ggwpez
added
the
D3-trivial 🧸
KiChjang
approved these changes
Aug 17, 2022
gilescope
approved these changes
Aug 17, 2022
|
is the change this is reverting already deployed to statemint? if not, we should get this patched on the next release before the change makes it to prod? |
Not sure how to best determine this, but I checked the 0.9.27 statemint runtime from here and it is not in there: subwasm metadata statemint_runtime-v9270.compact.compressed.wasm --module Uniques |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
changed the title
ggwpez
changed the title
|
bot merge |
paritytech-processbot
bot
deleted the
revert-11796-autoincrement-collectionId
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11796
The
AtLeast32BitUnsignedthat we added to theCollectionIdbreaks XCMv3.We need to find a better solution on how to do this.
Cumulus companion: paritytech/cumulus#1557
cc @KiChjang @Szegoo @shawntabrizi