Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clean up the logging output #12253

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Clean up the logging output #12253

merged 2 commits into from
Sep 14, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 13, 2022

Sadly trust-dns and libp2p::iface are printing stuff that isn't very informative and just confuses the user. So, we just disable logging output from both of these crates as we already have done this for other crates as well.

@bkchr
Clean up the logging output
41278e6 
Sadly `trust-dns` and `libp2p::iface` are printing stuff that isn't very informative and just
confuses the user. So, we just disable logging output from both of these crates as we already have
done this for other crates as well.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 13, 2022
@bkchr bkchr requested a review from a team September 13, 2022 12:37
BustaNit
BustaNit approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@BustaNit BustaNit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FMT LGTM

koute
koute approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference, do you have some examples of the logs they're printing?

@bkchr
Copy link
Member Author

bkchr commented Sep 14, 2022

Just for reference, do you have some examples of the logs they're printing?

For iface this would be:

2022-09-14 22:01:35 creating instance on iface 10.211.55.3    
2022-09-14 22:01:35 creating instance on iface 172.17.0.1    
2022-09-14 22:01:35 creating instance on iface 10.1.10.20    
2022-09-14 22:01:35 error sending packet on iface 10.1.10.20: Required key not available (os error 126)    
2022-09-14 22:01:35 error sending packet on iface 10.1.10.20: Required key not available (os error 126)    
2022-09-14 22:01:35 error sending packet on iface 10.1.10.20: Required key not available (os error 126)    
2022-09-14 22:01:35 error sending packet on iface 10.1.10.20: Required key not available (os error 126)

And for trust-dns this would be:

failed to associate send_message response to the sender

@bkchr bkchr merged commit 1dcb9ce into master Sep 14, 2022
@bkchr bkchr deleted the bkchr-clean-up-output branch September 14, 2022 20:08
@bkchr bkchr mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@bkchr @ark0f
Clean up the logging output (paritytech#12253)
f357a81 
* Clean up the logging output

Sadly `trust-dns` and `libp2p::iface` are printing stuff that isn't very informative and just
confuses the user. So, we just disable logging output from both of these crates as we already have
done this for other crates as well.

* FMT
@lexnv lexnv mentioned this pull request Sep 9, 2024
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BustaNit BustaNit BustaNit approved these changes

@skunert skunert skunert approved these changes

@koute koute koute approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @koute @skunert @BustaNit