Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump wasmtime to 1.0.0 #12317

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Bump wasmtime to 1.0.0 #12317

merged 1 commit into from
Sep 21, 2022

Conversation

koute
Copy link
Contributor

@koute koute commented Sep 21, 2022

This PR bumps our wasmtime dependency to the newest version (changelog)

I see no significant performance differences. There are two new features in 1.0 that are potentially significant and could benefit us - incremental compilation (compiling the runtimes is a significant bottleneck for us) and inline stack probes. However, they are disabled by default. I haven't enabled them yet as that would require more in-depth testing (which I do intend to do at a later date).

@koute koute requested a review from a team September 21, 2022 07:14
@koute koute added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 21, 2022
@bkchr
Copy link
Member

bkchr commented Sep 21, 2022

incremental compilation

In what way incremental compilation? Do you have a link with more information on this?

@koute
Copy link
Contributor Author

koute commented Sep 21, 2022

incremental compilation

In what way incremental compilation? Do you have a link with more information on this?

Quoting the changelog:

An incremental compilation cache for Cranelift has been added which can be enabled with Config::enable_incremental_compilation, and this option is disabled by default for now. The incremental compilation cache has been measured to improve compile times for cold uncached modules as well due to some wasm modules having similar-enough functions internally.

Assuming most of the code between runtime upgrades is going to be the same this has the potential to speed up our instantiation times in cases like e.g. the one I've linked to.

@bkchr
Copy link
Member

bkchr commented Sep 21, 2022

Okay. Sounds nice. Something to play around with. Could you open an issue for this? Maybe for Parachain PVFs that would be really nice.

@koute
Copy link
Contributor Author

koute commented Sep 21, 2022

Okay. Sounds nice. Something to play around with. Could you open an issue for this? Maybe for Parachain PVFs that would be really nice.

Done! paritytech/polkadot-sdk#33

@koute
Copy link
Contributor Author

koute commented Sep 21, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ae4ba19 into paritytech:master Sep 21, 2022
@athei athei mentioned this pull request Sep 21, 2022
Merged
ordian added a commit that referenced this pull request Sep 23, 2022
@ordian
Merge branch 'master' into ao-update-kvdb-and-co
45adc12 
* master:
  [Fix] parameter_types! dead code errors (#12340)
  [Feature] Sequential migration execution for try-runtime (#12319)
  bench: Use `_` instead  of `::` in auto-generated file names (#12332)
  Fast Unstake Pallet (#12129)
  Rename anonymous to pure proxy (#12283)
  Migrate remaining old decl_* macros to the new pallet attribute macros (#12271)
  pallet-utility: Disallow none origin (#12321)
  Make automatic storage deposits resistant against changing deposit prices (#12083)
  Format templates and fix `--steps` default value (#12286)
  Bump `wasmtime` to 1.0.0 (#12317)
  Introduce 'intermediate_insert' method to hide implementation details (#12215)
  Bound staking storage items (#12230)
  Use `array-bytes` for All Array/Bytes/Hex Operations (#12190)
  BREAKING: Rename Origin (#12258)
  Use temporary db for benchmarking (#12254)
  rpc: Implement `chainSpec` RPC API (#12261)
  Import target block body during warp sync (#12300)
  Proper naming wrt expectations (#12311)
  [ci] Revert cancel-pipeline job (#12309)
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@koute @ark0f
Bump wasmtime to 1.0.0 (paritytech#12317)
da9d9ba
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davxy davxy davxy approved these changes

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koute @bkchr @skunert @davxy